Remove IIFE wrapper from googleDriveAdapterHelper.js
Changed from IIFE pattern to direct object literal evaluation
Rationale:
- Global variable functions should evaluate to an object directly
- IIFE wrapper was unnecessary complexity
- Simpler pattern: code evaluates to object, not function that returns object
- Matches intended architecture for vm.Script module loading
Changes:
1. Removed IIFE wrapper:
- Before: (function createHelpers() { ... return {...} })()
- After: ({ ... })
2. Removed function indentation (2 spaces throughout file)
3. Updated constitution.md:
- Pattern description: 'IIFE returning object' → 'evaluates to a single object'
- Clarified: 'not wrapped in IIFE'
- Updated all pattern references
Structure:
- File defines classes and functions at top level
- Final expression is object literal referencing all functions
- When executed via vm.Script, evaluates to the object
- Object is assigned to globalVariableContext.googleDriveAdapterHelper
Benefits:
✅ Simpler pattern (no function wrapper)
✅ Clearer intent (direct object evaluation)
✅ Matches architecture description
✅ Easier to understand and maintain
✅ Same functionality, cleaner implementation
Before (IIFE):
After (Object Literal):
Testing:
✓ Syntax validated
✓ Server starts successfully
✓ Module loads: 'Loaded global functions: googleDriveAdapterHelper'
✓ All function calls work correctly
✓ Request handling works as expected
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
@@ -204,9 +204,9 @@ Follow-up TODOs:
|
||||
|
||||
**Helper Functions Pattern**: Pure utility functions (XML escaping, validation, formatting, routing) MAY be extracted to `src/globalVariables/googleDriveAdapterHelper.js` to improve readability and maintainability. The helpers module:
|
||||
- MUST be loaded via `vm.Script` (same isolation as proxy.js)
|
||||
- MUST return a single object with all helper functions
|
||||
- MUST evaluate to a single JavaScript object with all helper functions
|
||||
- MUST have ZERO imports/exports
|
||||
- Is injected as `helpers` global object into VM context
|
||||
- Is injected as `googleDriveAdapterHelper` global object into VM context
|
||||
- Contains ONLY pure utilities, NO business logic or state
|
||||
|
||||
### I. Zero External Imports or Exports from `src/proxyScripts/proxy.js` (NON-NEGOTIABLE)
|
||||
@@ -291,11 +291,11 @@ config/
|
||||
|
||||
**googleDriveAdapterHelper.js Pattern**:
|
||||
- MUST be loaded using `vm.Script` (same isolation as proxy.js)
|
||||
- MUST return single object with all helper functions via IIFE
|
||||
- MUST evaluate to a single JavaScript object (not wrapped in IIFE)
|
||||
- MUST have ZERO imports/exports (pure vm.Script execution)
|
||||
- Loaded by `loadGlobalVariables()` which scans for both JSON and JS files
|
||||
- Filename determines global key: `googleDriveAdapterHelper.js` → `globalVariableContext.helpers`
|
||||
- Injected as `helpers` global object into VM context
|
||||
- Filename determines global key: `googleDriveAdapterHelper.js` → `globalVariableContext.googleDriveAdapterHelper`
|
||||
- Injected as `googleDriveAdapterHelper` global object into VM context
|
||||
- Contains ONLY pure utilities: validators, formatters, XML, error mappers
|
||||
- MUST NOT contain: authentication, API calls, state, business decisions
|
||||
- Executed in context with full access to globalVMContext and globalVariableContext
|
||||
@@ -441,7 +441,6 @@ script.runInContext(context);
|
||||
10. **googleDriveAdapterHelper** - Pure utility functions object (OPTIONAL)
|
||||
- Purpose: Extracted helper functions for code organization
|
||||
- Source: `src/globalVariables/googleDriveAdapterHelper.js` loaded via `vm.Script`
|
||||
- Pattern: IIFE returning object with all helper functions
|
||||
- Loading: server.js loads via `loadGlobalVariables()` at startup
|
||||
- Generic Loading Pattern:
|
||||
- All .js files in globalVariables/ are loaded automatically
|
||||
|
||||
Reference in New Issue
Block a user