verint.com/obsidian-mcp
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity
20 Commits 2 Branches 9 Tags
964ffd3814102383341ada5a6fe7b7d6e47bbb1b
Commit Graph

3 Commits

Author SHA1 Message Date
Peter.Morton
8e2e8f858c fix: properly quote CLI parameters to handle filenames with spaces 
Fixed parameter quoting in file operations and search tools to handle
filenames and values containing spaces correctly.

Root Cause:
- Obsidian CLI requires quoting values with spaces: name="My Note"
- Previous implementation used unquoted format: name=My Note
- Shell would split on spaces, breaking multi-word filenames

Solution:
1. Created formatParam() helper in src/utils/cli-helpers.ts
   - Always quotes parameter values: param="value"
   - Handles spaces and special characters safely

2. Updated file-operations.ts (8 tools):
   - All file/path/content/name parameters now quoted
   - create, read, append, prepend, delete, move, rename, open

3. Updated search.ts (1 tool):
   - query, path, format, limit parameters now quoted
   - Fixes searches with multi-word queries

Changes:
- Before: cmdArgs.push(\`file=${name}\`)
- After: cmdArgs.push(formatParam('file', name))

Files changed:
- src/utils/cli-helpers.ts (new): formatParam() and buildCmdArgs() helpers
- src/tools/file-operations.ts: Use formatParam() for all parameters
- src/tools/search.ts: Use formatParam() for all parameters

Impact:
- File operations now work with multi-word filenames
- Search queries with spaces now work correctly
- Content parameters with newlines/special chars handled safely

Known Issue:
- links.ts, tags-aliases.ts, properties.ts still need similar fixes
- These tools have additional structural issues (wrong command names)
- Will be addressed in follow-up commit

Build: 0 errors

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
 2026-03-22 13:09:08 -05:00
Peter.Morton
d556183388 feat: add proper input schemas to all file operation tools 
Fixed all file operation tools to match Obsidian CLI specification
with complete inputSchema definitions for tools/list exposure.

Changes per tool (verified via 'obsidian help <command>'):

1. obsidian_create_note: ✅ Already fixed (name, path, content, template, overwrite, open, newtab)
2. obsidian_read_note: ✅ Already fixed (file, path)
3. obsidian_append_to_note: ✅ Already fixed (file, path, content, inline)
4. obsidian_prepend_to_note: Fixed - Added full schema (file, path, content, inline)
5. obsidian_delete_note: Fixed - Added full schema (file, path, permanent)
6. obsidian_move_note: Fixed - Added full schema (file, path, to)
7. obsidian_rename_note: Fixed - Added full schema (file, path, name)
8. obsidian_open_note: Fixed - Added full schema (file, path, newtab)

Command execution fixes:
- Changed all executeObsidianCommand('note', ...) to proper commands
  ('create', 'read', 'append', 'prepend', 'delete', 'move', 'rename', 'open')
- Changed parameter format from '--flag value' to 'param=value'
  (matches actual Obsidian CLI syntax)
- Removed identifier concatenation, now builds params properly:
  Before: ['command', identifier, '--flag', value]
  After: ['file=name'] or ['path=folder/note.md']

Removed tools:
- obsidian_duplicate_note: Not in Obsidian CLI spec
- obsidian_get_file_info: Not in Obsidian CLI (use 'file' command separately if needed)

Tool count reduced from 9 to 8 (removed non-existent commands).

All 8 file operation tools now have:
✅ Complete inputSchema with all parameters documented
✅ Correct command names matching Obsidian CLI
✅ Proper param=value format for CLI execution
✅ Required fields marked appropriately

Files changed:
- src/tools/file-operations.ts

Build: ✅ 0 errors
Impact: tools/list now returns complete schemas for all file ops

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
 2026-03-22 13:01:09 -05:00
Peter.Morton
622b28e42c feat: implement Obsidian MCP Bundle MVP (Phase 1-3) 
- Complete project setup with TypeScript, Jest, MCPB manifest
- Implement foundational infrastructure (CLI executor, logger, error handler)
- Add 9 file operation tools for User Story 1
- Full MCP protocol compliance with stdio transport
- Input validation and sanitization for security
- Comprehensive error handling with actionable messages
- Constitutional compliance: all 6 principles satisfied

MVP includes:
- obsidian_create_note, read, append, prepend, delete, move, rename, open, file_info
- Zod validation schemas for all parameters
- 30s timeout configuration with per-command overrides
- Stderr-only logging with sanitized output
- Graceful shutdown handling

Build: ✅ 0 errors, 0 vulnerabilities
Tasks: 48/167 complete (MVP milestone)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
 2026-03-22 11:21:38 -05:00